Prevent duplicate kernel startup #876
Conversation
| @@ -10,7 +10,8 @@ import type Kernel from "./../kernel"; | |||
|
|
|||
| class Store { | |||
| subscriptions = new CompositeDisposable(); | |||
| @observable runningKernels = new Map(); | |||
| @observable startingKernels: Map<string, boolean> = new Map(); | |||
| @observable runningKernels: Map<string, Kernel> = new Map(); | |||
| @observable editor = atom.workspace.getActiveTextEditor(); | |||
There was a problem hiding this comment.
ideally we could do this without even adding startingKernels, but we would have to somehow give store the new kernel before the kernel is actually ready. I suppose we could promisify or something, but am eager to see what you all think.
There was a problem hiding this comment.
I like the idea of having a promise or to just give store a new kernel even if it's not fully connected yet. But this likely requires some refactorings that will be a lot easier once #858 is closed.
There was a problem hiding this comment.
I agree. I'll use the phrase "we can iterate" here 😄
|
This is ready for review! There haven't been any comments on this or #876, what do you think? @nikitakit I remembered that you had mentioned this issue in #780, do you have any feedback? |
| @@ -10,7 +10,8 @@ import type Kernel from "./../kernel"; | |||
|
|
|||
| class Store { | |||
| subscriptions = new CompositeDisposable(); | |||
| @observable runningKernels = new Map(); | |||
| @observable startingKernels: Map<string, boolean> = new Map(); | |||
| @observable runningKernels: Map<string, Kernel> = new Map(); | |||
| @observable editor = atom.workspace.getActiveTextEditor(); | |||
There was a problem hiding this comment.
I like the idea of having a promise or to just give store a new kernel even if it's not fully connected yet. But this likely requires some refactorings that will be a lot easier once #858 is closed.
|
🆒 |
Since we rely on
store.kernelto indicate if a new kernel should be startedstoreneeds to be aware af startup pretty much immediately to avoid duplicate kernels. See #870 for a wordier explanation.The idea here is to somehow fail silently instead of creating dup kernels that may not shut down properly. I would be grateful for feedback!
To Duplicate:
ctrl-enteron 2 or more lines quickly